Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

package-lock still shows prior versions after a release #85

Open
starpit opened this issue Dec 6, 2022 · 2 comments
Open

package-lock still shows prior versions after a release #85

starpit opened this issue Dec 6, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@starpit
Copy link

starpit commented Dec 6, 2022

Heya, thanks for this plugin, it's great. I have found one minor discrepancy, that seems like it might be a bug? After running a release, if i then run npm install, I notice that package-lock now shows updates to the versions. I have attached an example diff.

diff --git a/package-lock.json b/package-lock.json
index 0bdbe48..6dde219 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -1,12 +1,12 @@
 {
   "name": "madwizard-packages",
-  "version": "2.0.2",
+  "version": "2.0.4",
   "lockfileVersion": 2,
   "requires": true,
   "packages": {
     "": {
       "name": "madwizard-packages",
-      "version": "2.0.2",
+      "version": "2.0.4",
       "license": "Apache-2.0",
       "workspaces": [
         "packages/madwizard",
@@ -5231,7 +5231,7 @@
       }
     },
     "packages/madwizard": {
-      "version": "2.0.2",
+      "version": "2.0.4",
       "license": "Apache-2.0",
       "dependencies": {
         "chalk": "^5.1.2",
@@ -5295,10 +5295,10 @@
       }
     },
     "packages/madwizard-cli": {
-      "version": "2.0.2",
+      "version": "2.0.4",
       "dependencies": {
         "@guidebooks/store": "^1.7.1",
-        "madwizard": "^2.0.2"
+        "madwizard": "^2.0.4"
       },
       "bin": {
         "madwizard": "madwizard.js",
@@ -7086,7 +7086,7 @@
       "version": "file:packages/madwizard-cli",
       "requires": {
         "@guidebooks/store": "^1.7.1",
-        "madwizard": "^2.0.2"
+        "madwizard": "^2.0.4"
       },
@rwjblue
Copy link
Collaborator

rwjblue commented Jan 17, 2023

Thanks for reporting! This is definitely not good 😸

@rwjblue
Copy link
Collaborator

rwjblue commented Jan 15, 2024

Ya, we chatted about this over in #110. We basically need to detect the package manager and run npm i (just like we did pnpm install in that PR).

Would love someone to give this a try...

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants