Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Docs]: Update Jokes tutorial to use v2 route convention #5986

Closed
1 task done
thomasgauvin opened this issue Apr 2, 2023 · 4 comments
Closed
1 task done

[Docs]: Update Jokes tutorial to use v2 route convention #5986

thomasgauvin opened this issue Apr 2, 2023 · 4 comments
Labels

Comments

@thomasgauvin
Copy link

What version of Remix are you using?

1.15

Are all your remix dependencies & dev-dependencies using the same version?

  • Yes

Steps to Reproduce

  1. npx create-remix@latest
  2. Adjust the app/root.tsx file, create the app/routes/jokes.tsx file, create the app/routes/jokes/index.tsx file as documented in the App tutorial https://remix.run/docs/en/1.15.0/tutorials/jokes#routes
  3. npm i, npm run dev

Expected Behavior

image

Actual Behavior

Screenshot 2023-04-02 at 11 55 10 AM
FsuBiW7XoAQH2cE
FsuDMHXWAAAq4k7
FsuDJn1WIAIWP8b

@thomasgauvin
Copy link
Author

Related #5216 remix-run/examples#196

@thomasgauvin
Copy link
Author

After doing some digging, seems that the create-next-app defaults to using the v2 route convention but the tutorial has not been updated. You can adjust by turning off v2_routeConvention in remix.config.js

Screenshot 2023-04-02 at 12 20 02 PM

@brophdawg11 brophdawg11 changed the title Getting Route ID Collision: "routes/jokes" when following the App Tutorial [Docs]: Update Jokes tutorial to use v2 route convention May 4, 2023
@brophdawg11
Copy link
Contributor

Yeah this looks like the tutorial is just a bit stale and need to be updated to reflect the v2 routing structure. We'd happily accept a PR for this if someone wants to give it a shot!

@MichaelDeBoey
Copy link
Member

This is done in #6050

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants