New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Azimuth correction for hemisphere is not clear from docstrings #9

Open

rabwent11 opened this issue Jun 3, 2020 · 0 comments

rabwent11 commented Jun 3, 2020

In pv.py >> def run_model(...) docstring:
"Azimuth angle (degrees, 180 = towards equator)".

In trigon.py >> aperture_irradiance(..) docstring:
"0 = towards pole, going clockwise, 3.14 = towards equator."

In trigon.py >> aperture_irradiance(..) lines 230-231, correction is made by rotating azimuth clockwise by pi if lat in southern hemisphere:

if coords[0] < 0:
    azimuth = azimuth + np.pi

Docstrings could be updated to say "Azimuth angle (degrees, 180 = South)" and "0 = towards North, going clockwise, 3.14 = towards South."

The text was updated successfully, but these errors were encountered:

# for free to join this conversation on GitHub. Already have an account? # to comment