Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

npm packageManager updates lose other npm updates if grouped together #31325

Closed
rarkins opened this issue Sep 11, 2024 Discussed in #31323 · 3 comments · Fixed by #31326
Closed

npm packageManager updates lose other npm updates if grouped together #31325

rarkins opened this issue Sep 11, 2024 Discussed in #31323 · 3 comments · Fixed by #31326
Assignees
Labels
manager:npm package.json files (npm/yarn/pnpm) priority-2-high Bugs impacting wide number of users or very important features regression Issue about a regression bug, or the PR caused it type:bug Bug fix of existing functionality

Comments

@rarkins
Copy link
Collaborator

rarkins commented Sep 11, 2024

Discussed in #31323

Originally posted by ChristianIvicevic September 11, 2024

What would you like help with?

I think I found a bug

How are you running Renovate?

Mend Renovate hosted app on github.com

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

No response

Please tell us more about your question or problem

All of my projects using Renovate are currently failing during pnpm install in my GitHub action due to an updated lockfile that doesn't match the package.json because Renovate did not correctly update that as part of the PR. An example of a public PR that has this issue at the time of writing this is the following: ChristianIvicevic/adios-axios#38

Only the packageManager key is updated but the other updated dependency as part of the PR are not reflected in the package.json only in the lockfile.

I scrolled through the logs but there is no error or warning indicating problems.

Logs (if relevant)

I wasn't able to find the relevant parts of the logs so I decided to copy all of it: https://gist.github.com/ChristianIvicevic/ef9fb2e68a01bdd0fe75aaf72b36f8a6

@rarkins rarkins added type:bug Bug fix of existing functionality priority-2-high Bugs impacting wide number of users or very important features manager:npm package.json files (npm/yarn/pnpm) regression Issue about a regression bug, or the PR caused it labels Sep 11, 2024
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 38.77.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ChristianIvicevic
Copy link

Is there a way to track when the fix for this is deployed to the hosted version?

@viceice
Copy link
Member

viceice commented Sep 14, 2024

Is there a way to track when the fix for this is deployed to the hosted version?

it's usually done once a week. we've a slack channel where it's announced

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
manager:npm package.json files (npm/yarn/pnpm) priority-2-high Bugs impacting wide number of users or very important features regression Issue about a regression bug, or the PR caused it type:bug Bug fix of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants