Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: use yaml instead of js-yaml for parsing YAML files #31336

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

secustor
Copy link
Collaborator

Changes

Replaces js-yaml with yaml as the former has not received updates in the last 3 years.

Also this library supports adding tag handling, which would allow us to natevily handle !reference tags in GitlabCI

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@secustor secustor requested a review from viceice September 11, 2024 14:14
@websi websi mentioned this pull request Sep 13, 2024
6 tasks
@rarkins rarkins requested a review from viceice September 16, 2024 05:08
viceice
viceice previously approved these changes Sep 16, 2024
@secustor secustor added this pull request to the merge queue Sep 16, 2024
Merged via the queue into renovatebot:main with commit d74ba70 Sep 16, 2024
38 checks passed
@secustor secustor deleted the refactor/use-yaml branch September 16, 2024 18:13
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 38.84.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

websi added a commit to dkd/renovate that referenced this pull request Oct 4, 2024
Since renovatebot#31336 the replacement of the reference tag from GitLab is not needed anymore
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 19, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants