Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Renovate doesn't prune branches which don't target default branch #31356

Closed
viceice opened this issue Sep 12, 2024 · 1 comment · Fixed by #31357
Closed

Renovate doesn't prune branches which don't target default branch #31356

viceice opened this issue Sep 12, 2024 · 1 comment · Fixed by #31357
Assignees
Labels
core:git Related to our git platform layer priority-2-high Bugs impacting wide number of users or very important features status:in-progress Someone is working on implementation type:bug Bug fix of existing functionality

Comments

@viceice
Copy link
Member

viceice commented Sep 12, 2024

Describe the proposed change(s).

Renovate doesn't prune branches, when they target a different base branch because it compares it with default branch for modifications.

const branchIsModified = await scm.isBranchModified(
branchName,
config.defaultBranch!,
);

We need to pass the base branch for each renovate branch.

@viceice viceice added type:bug Bug fix of existing functionality priority-2-high Bugs impacting wide number of users or very important features core:git Related to our git platform layer labels Sep 12, 2024
@viceice viceice self-assigned this Sep 12, 2024
@viceice viceice added the status:in-progress Someone is working on implementation label Sep 12, 2024
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 38.77.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
core:git Related to our git platform layer priority-2-high Bugs impacting wide number of users or very important features status:in-progress Someone is working on implementation type:bug Bug fix of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants