Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(datasource/maven): Maven Central has no index.html #32295

Conversation

aikebah
Copy link
Contributor

@aikebah aikebah commented Nov 2, 2024

Fixes the current misbehaviour of the maven datasource requesting index.html at the package-level, whereas the intended html page is served for the folder. Maven Central always responds HTTP 404 when requested for index.html

Changes

Change the maven datasource from requesting the non-existent <package-root-folder>/index.html to the proper <package-root-folder> to obtain the intended HTML-directory-listing of versions and their timestamps.

Updates the related testcases accordingly.

Context

As indicated in my remark on discussion 25461 the first remark made in the opening post, that index.html is non-existent was never addressed and still existent in the codebase of renovate resulting in every attempt for getting releases from Maven Central running into HTTP 404 errors.

Following up on the response given this is the PR that would resolve that issue.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Fixes the current misbehaviour of the maven datasource requesting
index.html at the package-level, whereas the intended html page
is served for the folder. Maven Central always responds HTTP 404
when requested for index.html
@rarkins rarkins requested a review from zharinov November 2, 2024 22:11
@viceice viceice changed the title fix(maven): Maven Central has no index.html fix(datasource/maven): Maven Central has no index.html Nov 3, 2024
@rarkins rarkins added this pull request to the merge queue Nov 10, 2024
Merged via the queue into renovatebot:main with commit 957d199 Nov 10, 2024
39 checks passed
@aikebah aikebah deleted the fix/discuss-25461-mavencentral-has-no-index-html branch November 10, 2024 15:44
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants