Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Feature-Request] RegexManager Checksum-Download Support #7928

Closed
Preisschild opened this issue Dec 9, 2020 · 2 comments · Fixed by #10947
Closed

[Feature-Request] RegexManager Checksum-Download Support #7928

Preisschild opened this issue Dec 9, 2020 · 2 comments · Fixed by #10947
Labels
datasource:github-releases priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality)

Comments

@Preisschild
Copy link
Contributor

Preisschild commented Dec 9, 2020

What would you like Renovate to be able to do?

I use a regexmanager (with github-releases datasource) to update versions of tooling inside Dockerfiles. in the end it looks like this:

# renovate: datasource=github-releases depName=GoogleContainerTools/skaffold
ARG SKAFFOLD_VERSION=v1.16.0
ARG SKAFFOLD_CHECKSUM=9041feb75a5fc15c1159f1e25d0dd781ecf0ff9fe37190174e61822a47c60b1d

With the RegexManager looking like this.

"regexManagers": [
    {
      "fileMatch": ["(^|/|\\.)Dockerfile$", "(^|/)Dockerfile\\.[^/]*$"],
      "matchStrings": [
        "# renovate: datasource=(?<datasource>[a-z-]+?) depName=(?<depName>.+?)(?: versioning=(?<versioning>[a-z-0-9]+?))?\\s(?:ENV|ARG) .+?_VERSION=(?<currentValue>.+?)\\s"
      ],
      "versioningTemplate": "{{#if versioning}}{{versioning}}{{else}}semver{{/if}}"
    }
]

This works great for updating the Version, but it would also be cool if Renovate could update the Checksum (in this example ARG SKAFFOLD_CHECKSUM).

Did you already have any implementation ideas?
We could add a capture group that captures checksumUrl and another one that captures currentChecksumValue. This signals to renovate that it should update the checksum by downloading checksumUrl and passing the body.

Edit: We'd also need to allow inserting the new version into the url

@HonkingGoose HonkingGoose added manager:dockerfile Dockerfile files priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality) datasource:github-releases labels Dec 10, 2020
@Preisschild
Copy link
Contributor Author

@HonkingGoose I think the manager got mislabeled. I mean the regexmanager.

@HonkingGoose
Copy link
Collaborator

We don't have a RegEx manager label yet, so I thought this seems to apply to Dockerfiles, I'll stick a manager:dockerfile label on it.

I'll remove the manager:dockerfile label. 😄

@HonkingGoose HonkingGoose removed the manager:dockerfile Dockerfile files label Dec 10, 2020
@rarkins rarkins added the status:requirements Full requirements are not yet known, so implementation should not be started label Jan 12, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
datasource:github-releases priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants