Several profiles didn't always update correctly

[jpggithub]

I try almost all profile options on two different phones with two different versions of Android.

Conclusion:

• The Outline page does not update always in the same manner.
• The effectiveness of the different options is not always the same too.

The test is made with Battery is or is not discharging event.
Each profile selects only one option on/off or normal/silent sound or manual/auto brightnesse
Battery is charging -> select profile with option on
Battery is discharging -> select profile with option off
Then I put the power on/off several times, waiting between both. I tried to activate/desactivate the functionality by the parameters of the phone if Easer didn't works correctly to see what works (on or off).
I had several crashes during the tests but I didn't succeed to identify the conditions to predict them.

Results of the test below.

• With Samsung Galaxy Note 2, Android 5.1.1, CM 12.1
  bluetooth: everything works fine
  auto rotation: everything works fine
  hotspot: everything works fine
  ring: almost ok but the option silent activate "only priority rings", not real silent mode.
  data on: page updated, but doesn't put data on
  data off: page not updated, doesn't put data off
  wifi on: page updated, but doesn't put wifi on
  wifi off: page not updated, doesn't put data off
  brightness auto when discharging: page updated but do nothing on brightness
  brightness manual when charging: not updated and do nothing on brightness

• With Samsung S4, Android 6.0.1, LineageOS 13.0
  bluetooth: everything works fine
  ring: almost ok but the option silent activate "only priority rings", not real silent mode.
  wifi: page updated, but doesn't activate nor desactivate wifi
  hotspot off: page updated but doesn't desactivate hotspot
  hotspot on: page not updated and doesn't activate hotspot
  data on: page updated, but doesn't put data on
  data off: page not updated, doesn't put data off
  auto rotation on or off: crash Easer
  brightness auto when discharging: page updated but do nothing on brightness
  brightness manual when charging: page not updated and do nothing on brightness

Alright, I hope that this tests will be helpful for this already promising app! ;-)

[renyuneyun]

Thanks a lot for the info :)

One quick check: did you allow easer to change system settings and wifi settings (in either android permission settings or other permission setting softwares)?
The brightness and wifi issue shouldn't happen so this is the best guess (although it doesn't seem to be true because auto rotation works).

I remember the silent mode issue would happen on Android 7 onwards (so I delayed solving this at first), but it seems I'm wrong.

Putting data on/off, hostspot on/off and (potentially in the future) airplane mode on/off would use non API methods (by reflection, whichever that means), so they all may fail on some devices (I should add a note in the wiki page). Some people could solve (maybe some maybe all of) these by moving Easer as a system app (requiring root permission or a custom recovery). But as said elsewhere, a "root settings" option would be added in the future in the hope of fewer confusion.

p.s. I made some changes (added logging to disk functionality) in v0.3.7. Probably from that on debugging would be easier.

[jpggithub]

I update this issue with Easer 0.4.2.1.
I verified that all the asked permissions were given before the tests on the both smartphones.

• With Samsung Galaxy Note 2, Android 5.1.1, CM 12.1
  bluetooth: everything works fine as before
  auto rotation: everything works fine as before
  hotspot: everything works fine as before
  ring: almost ok but the option silent activate "only priority rings", not real silent mode. (same issue)
  data on: page updated, but doesn't put data on (same issue)
  data off: page not updated, doesn't put data off (same issue)
  wifi on: page updated and put wifi on (ok, it wasn't the case before)
  wifi off: page not updated, doesn't put wifi off (same issue)
  brightness auto when discharging: page updated but do nothing on brightness (same issue)
  brightness manual when charging: not updated and do nothing on brightness (same issue)

• With Samsung S4, Android 6.0.1, LineageOS 13.0
  bluetooth: everything works fine as before
  ring: almost ok but the option silent activate "only priority rings", not real silent mode (same issue).
  wifi on: page updated on and wifi activated (same issue)
  wifi off: page not updated and wifi not activated (same issue)
  hotspot: everything works fine (thanks, it wasn't the case before and that's why I need Easer ;-)
  data on: page updated (only if data was already on), but doesn't put data on (when it's off) (different behaviour that my previous test but perhaps my test was not complete...)
  data off: page updated (only if data was already off), doesn't put data off (same remark as for "data on")
  auto rotation: everything works fine (ok, it wasn't the case before)
  brightness auto when discharging: page updated but do nothing on brightness (same issue)
  brightness manual when charging: page not updated and do nothing on brightness (same issue)

[renyuneyun]

Ok, I figured out how to make brightness change work (but still don't understand why) in this post. It will be fixed in v0.4.6.

There is a trick I need to do with ringer mode (see the previous post), so the behavior is "expected" (to be wrong). It will be fixed soon (probably in v0.4.6).

Mobile data is not guarenteed to work on un-rooted devices (neither does hotspot actually). There is now a "rooted features" in v0.4.4, which should overcome this problem.

The wifi issue seems to be strange. I tested Easer on the emulator, my phone and another phone, and it works correctly on these devices...
Could you post the log (if you enabled the loging function in Easer's setting, it will be located under /sdcard/logger/) after changing wifi status (either to be on or off should be enough for now)? There may be something useful.

[renyuneyun]

Switching ringer mode to silent is implemented, and a new bug was reported in #45 (and should have been fixed).

The wifi issue is weird because managing wifi is official Android API... I still can't reproduce until now.
The only guess is permission issue which should been resolved in v0.4.7 because of the introduction of runtime permission checks (in order to confirm it's happening, you may need to click the "wifi" selection in the list of operations when creating/modifying a profile).