Fix infinite loop when an empty or blank password is given #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pg_repack hanged when entering an empty or blank string at the password prompt.
|
This should help with #315. |
za-arthur
reviewed
Mar 24, 2023
There was a problem hiding this comment.
Thanks for the PR. What about instead of another infinite loop like here:
do {
buf = simple_prompt("Password: ", BUFSIZE, false);
} while (strlen(buf) == 0);
just fail with error no password supplied after prompt_for_password() returned empty string?
This will be similar behavior to psql's.
|
@egashira-yusuke Since this PR is fixing an issue with empty passwords: can you add a test which shows that empty passwords are no longer an issue? |
|
Fixed in #354 instead. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fix for #299.
The connection string used by pg_repack was missing password quotes.
It also adds retry processing so that if an empty password is entered, the password prompt does not remember it.