Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Missing changes in swap_head_or_index_files() #378

Open
za-arthur opened this issue Jan 5, 2024 · 0 comments
Open

Missing changes in swap_head_or_index_files() #378

za-arthur opened this issue Jan 5, 2024 · 0 comments

Comments

@za-arthur
Copy link
Collaborator

za-arthur commented Jan 5, 2024

This is follow up ticket. See the another ticket #152 and pull requests #157, #377.

It seems to me that besides swapping relfrozenxid, relfrozenxid and relallvisible there are other changes which are missing in swap_head_or_index_files() comparing to Postgres swap_relation_files().

We don't need to migrate some code:

At this point I'm not sure if we need to migrate the following changes:

  • Call RelationClearMissing(). It seems it isn't harm to not call it. What it does is that it sets atthasmissing to false, which means that there are no values in a tables which miss default value of an attribute.
  • Support swap_toast_by_content. I'm not sure if it is necessary to support swapping toast tables by content. See the code where Postgres decides when to swap toast tables by content.

And it might be good to do the following changes:

I think that the following changes are important and needs to be migrated:

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

1 participant