From 04a540e30694544ea5dba5450eb48fb564d49884 Mon Sep 17 00:00:00 2001 From: Mike Fix Date: Sun, 30 Aug 2020 17:38:33 -0700 Subject: [PATCH] Revert "fix issue #60" This reverts commit 397cdc119e509697e87f331667f46686712b0965. --- src/pull/labeled.js | 12 ++++++------ test/index.test.js | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/pull/labeled.js b/src/pull/labeled.js index 5918d7b..3145568 100644 --- a/src/pull/labeled.js +++ b/src/pull/labeled.js @@ -142,12 +142,12 @@ module.exports.process = (robot) => async ({ (s) => s.conclusion !== CONCLUSION.SUCCESS && s.conclusion !== CONCLUSION.NEUTRAL && - s.conclusion !== CONCLUSION.SKIPPED - // Currently check suites like https://github.com/NLog/NLog/pull/3296/checks were being - // queued and never concluding. You can see that in this API response: - // https://api.github.com/repos/NLog/Nlog/commits/2c8f7471648f22fa5dc9bf6db53e96fae061fc0a/check-suites - // Corresponding issue: https://github.com/mfix22/ranger/issues/60 - // s.conclusion !== null + s.conclusion !== CONCLUSION.SKIPPED && + // TODO remove this. Currently check suites like https://github.com/NLog/NLog/pull/3296/checks are being + // queued and never concluding. You can see that in this API response: + // https://api.github.com/repos/NLog/Nlog/commits/2c8f7471648f22fa5dc9bf6db53e96fae061fc0a/check-suites + // Corresponding issue: https://github.com/mfix22/ranger/issues/60 + s.conclusion !== null ) ) { throw new Retry() diff --git a/test/index.test.js b/test/index.test.js index c4022f1..47e3426 100644 --- a/test/index.test.js +++ b/test/index.test.js @@ -605,7 +605,7 @@ describe('pull_request', () => { }) test.each([ - // [null, true], was used for https://github.com/dawnlabs/ranger/issues/60 + [null, true], // TODO https://github.com/dawnlabs/ranger/issues/60 [CONCLUSION.SUCCESS, true], [CONCLUSION.NEUTRAL, true], [CONCLUSION.TIMED_OUT, false],