Add buttons and shortcuts for zooming the whole GUI #265
Conversation
You can now zoom the whole GUI with ⌘+ and ⌘- (or Ctrl+Plus/Ctrl+Minus), just like on the web, or an electron app.
|
getting |
|
also introduces a curious bug (doubled checked it really happens only on this branch and it does): When the window starts its life on a high dpi screen and goes to a lower dpi screen, the title bar now doubles in size:
|
|
Ooh, thanks for finding those problems! I'll get right on it |
|
There may still be some work to do… Seems like EDIT: will be fixed by emilk/egui#2256 |
|
|
||
| // On Mac, we share the same space as the native red/yellow/green close/minimize/maximize buttons. | ||
| // This means we need to make room for them. | ||
| let native_buttons_size_in_native_scale = egui::vec2(64.0, 24.0); // source: I measured /emilk |
There was a problem hiding this comment.
This is a Mac-only setting.
| // On the web the browser controls the zoom | ||
| if !frame.is_web() { | ||
| egui::gui_zoom::zoom_menu_buttons(ui, frame.info().native_pixels_per_point); | ||
| ui.separator(); | ||
| } |
There was a problem hiding this comment.
actually I can't zoom at all on the web since we grab cmd +
There was a problem hiding this comment.
Where do we grab cmd +?
I can zoom with cmd+/- on Mac Firefox on https://www.egui.rs/ - can you?
There was a problem hiding this comment.
ah apologies, I meant cmd + scrollwheel. Cmd + works
# Conflicts: # Cargo.lock # Cargo.toml
|
Nice! A little bit disappointing that it doesn't seem to respond to ctrl+ or ctrl- when using the keys on the num pad on Windows by default. |
|
Filed a bug for that now! ⬆️ |
You can now zoom the whole GUI with ⌘+ and ⌘- (or Ctrl+Plus/Ctrl+Minus), just like on the web, or an electron app.
Based on emilk/egui#2239
Checklist
CHANGELOG.md(if this is a big enough change to warrant it)