Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Correct comparison operator in Array.every() method #224

Merged
merged 1 commit into from
May 25, 2024
Merged

Correct comparison operator in Array.every() method #224

merged 1 commit into from
May 25, 2024

Conversation

WooWan
Copy link
Contributor

@WooWan WooWan commented May 25, 2024 •
edited
Loading

Fix typo in Array.every() comparison operator
Yay, my first contribution

let array = [1, 2, 3, 4]

//before
Console.log(array->Array.every(num => num > 4)) // true

//after
Console.log(array->Array.every(num => num <= 4)) // true

cknitt
cknitt approved these changes May 25, 2024
View reviewed changes
Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 👍

@zth zth merged commit e9a3cce into rescript-lang:main May 25, 2024
6 checks passed
illusionalsagacity pushed a commit to illusionalsagacity/rescript-core that referenced this pull request Jun 19, 2024
@WooWan @illusionalsagacity
correct comparison operator in Array.every() method (rescript-lang#224)
955b230
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@cknitt cknitt cknitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WooWan @cknitt @zth