Skip to content

add Char module #229

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

add Char module #229

wants to merge 1 commit into from

Conversation

aspeddro
Copy link
Contributor

@aspeddro aspeddro commented Jun 5, 2024

Perhaps add chrOpt, return option<chr>, @zth, @fhammerschmidt?

TODO:

  • Get rid of PervasivesU
  • Add docstrings
  • Update CHANGELOG.md

Close #228

aspeddro
aspeddro commented Jun 5, 2024
View reviewed changes
src/Core__Char.resi

/* The following is for system use only. Do not call directly. */

external unsafeChr: int => char = "%identity"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename to chrUnsafe

@fhammerschmidt
Copy link
Member

Yes, a chrOpt that checks if a given int is in the valid char range and only then returns a Some(char) is missing currently, imo.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Char module
2 participants
@aspeddro @fhammerschmidt