Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

sadd deprecation warning #772

Open
Jakanapes opened this issue Jun 22, 2023 · 1 comment
Open

sadd deprecation warning #772

Jakanapes opened this issue Jun 22, 2023 · 1 comment

Comments

@Jakanapes
Copy link

use with redis 4.8.1 results in

Redis#sadd will always return an Integer in Redis 5.0.0. Use Redis#sadd? instead.(called from: /Users/jakanapes/.gem/ruby/3.1.3/gems/redis-namespace-1.11.0/lib/redis/namespace.rb:564:in `wrapped_send')

I can see it being called here

/Users/jakanapes/.gem/ruby/3.1.3/gems/resque-scheduler-4.9.0/lib/resque/scheduler/delaying_extensions.rb:93:in `delayed_push'

@michelleheh
Copy link

We got a similar warnings, and our logs are flooded with the following.

Redis#sadd will always return an Integer in Redis 5.0.0. Use Redis#sadd? instead.

We tracked it down to https://github.com/resque/resque-scheduler/blob/master/lib/resque/scheduler/scheduling_extensions.rb where there are 3 usages of redis.sadd.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants