Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use siunitx multi uncertainty descriptors #46

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Splines
Copy link
Collaborator

@Splines Splines commented Apr 12, 2024

This fixes #31, also see josephwright/siunitx#725.

Config

Recommended sisetup with this change:

\sisetup{separate-uncertainty=true,uncertainty-descriptor-mode=subscript}

For reviewers

  • We might have to discuss what we think about this.
  • Please also test the output in a real LaTeX document

@Splines Splines added the enhancement New feature or request label Apr 12, 2024
@Splines Splines self-assigned this Apr 12, 2024
@Splines Splines removed the enhancement New feature or request label Apr 12, 2024
@Splines Splines requested a review from paul019 April 12, 2024 17:34
@Splines Splines marked this pull request as ready for review April 12, 2024 17:34
paul019
paul019 previously approved these changes Apr 21, 2024
@Splines
Copy link
Collaborator Author

Splines commented Sep 11, 2024

If we merged this, many users cannot use our library and are forced to upgrade to a newer siunitx version as described in my comment here. At least, things don't look so badly anymore for Ubuntu 24 (e.g. Ubuntu 24.04.1 LTS, codename noble) where sudo apt texlive-science comes shipped with siunitx version 2024-01-25 v3.3.10.

Please also take note of my comment here.

In my opinion, we should just go full-in on siunitx and assume users to have one of the newer versions available, e.g. siunitx version 3.1.0 with built-in multi-uncertainty support. If they don't have this version of siunitx available yet, we provide the siunitx_fallback flag for them to fall back to our more "hacky" approach (*), but advise them to use LaTeX without a package manager in a custom install (which probably only the minority of users will do, as I suspect most Linux users to install LaTeX through the package repository, e.g. sudo apt texlive-science.

(*) see our LatexStringifier that basically only relies on the \unit{} command by siunitx.

@Splines
Copy link
Collaborator Author

Splines commented Sep 11, 2024

@paul019 You haven't checked the checkboxes yet in my PR comment at the very top. Could you read through them?

@Splines Splines changed the title Use siunitx multi uncertainty descriptors Use siunitx multi uncertainty descriptors [might want to close] Sep 13, 2024
@Splines Splines changed the title Use siunitx multi uncertainty descriptors [might want to close] Use siunitx multi uncertainty descriptors Sep 21, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple uncertainties: print same number of digits
2 participants