Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ToC starting at the bottom of the page #388

Closed
xyeLz opened this issue Aug 16, 2022 · 5 comments
Closed

ToC starting at the bottom of the page #388

xyeLz opened this issue Aug 16, 2022 · 5 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@xyeLz
Copy link

xyeLz commented Aug 16, 2022

Not sure how this occurred but presently, the ToC on my https://retypetest.pages.dev/reference/glossary/ page (in Edge on Windows 11) is starting at the bottom:

gap

All other pages are fine; however, if I access another page directly from the Glossary page, the same issue occurs:

gap2

If I refresh that page, it's fine. But once I return to Glossary, the issue recurs:

gap3

@geoffreymcgill geoffreymcgill self-assigned this Aug 16, 2022
@geoffreymcgill
Copy link
Collaborator

It looks like there is a JavaScript error being triggered on the page. We will have to investigate and try to figure out why.

Are you able to share or link me to the .md source for that page? Using the original source should help us be able to recreate and isolate the error.

@xyeLz
Copy link
Author

xyeLz commented Aug 16, 2022

Of course! I just made my repo public: https://github.com/alukosdev/retypetest

@geoffreymcgill
Copy link
Collaborator

I was able to isolate the issue and it looks like it's a bug with stacking Panel components when at least one of the Panels do not have any content.

The following sample will reproduce the JavaScript error:

=== Panel 1
One
=== Panel 2
===

If you add content to all the Panels, then no js error is throw. For example:

=== Panel 1
One
=== Panel 2
Two
===

If there only one Panel and no content, then Retype is working fine too:

=== Panel 1
===

The issue only occurs when two or more Panels are stacked and at least one of the Panels does not contain some content.

Adding a regular space character to the empty will not work-around the problem as whitespace is ignore, but you can add a   char. For example:

=== Panel 1
One
=== Panel 2
 
===

Using a snippet of content from your # A section, you can work-around the bug by adding a   inside of each collapsed Panel. The following sample demonstrates:

==- Application Certification
The application meets technical requirements.
==- Application Normative Framework (ANF)
 
==- Application Programming Interface (API)
 
===-

I am tagging this as a defect and we try and fix right away and include in the next release of Retype. I will keep this thread updated with our progress.

I apologize for the bug. We should have caught this earlier. This was a good find and thanks for bringing to our attention.

@geoffreymcgill geoffreymcgill added the bug Something isn't working label Aug 16, 2022
@geoffreymcgill geoffreymcgill added this to the v3.0 milestone Aug 16, 2022
@xyeLz
Copy link
Author

xyeLz commented Aug 16, 2022

No problem at all. I appreciate the quick response and identification of the issue. I could suggest an alternate feature for panels with no content: having them show anyways but drop down no content; however, I also like being able to "stage" certain words that I haven't defined yet and not have them appear, so I'm torn on this one. ;) In any case, thank you!

@geoffreymcgill
Copy link
Collaborator

This issue has been fixed and I can confirm your glossary.md page now renders correctly.

Screen Shot 2022-08-17 at 1 36 57 PM

The fix will be included in the next public release of Retype.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants