Use is new instead of id on save (#260)

* added test to service and fix test factory
* prettier
* detail
* fix-resource-has-one-relationships
* added include_get and include_save params to IParamsResource
* replaced ID for is_new and added tests

Author: maxi7587

CHANGELOG.md

@@ -4,11 +4,12 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [Unreleased]
+## [2.1.15] - 2020-01-17
 
 ### Added
 
 -   Added include_get and include_save to IResourceParams
+-   Resource's save methods uses is_new instead of ID property to select between POST and PATCH
 
 ## [2.1.14] - 2019-10-24
 

src/package.json

@@ -1,6 +1,6 @@
 {
     "name": "ngx-jsonapi",
-    "version": "2.1.14",
+    "version": "2.1.15",
     "description": "JSON API library for Angular",
     "module": "ngx-jsonapi/@ngx-jsonapi/ngx-jsonapi.es5.js",
     "es2015": "ngx-jsonapi/@ngx-jsonapi/ngx-jsonapi.js",

src/resource-integration.spec.ts

@@ -9,6 +9,7 @@ import { HttpClient, HttpEvent, HttpHandler, HttpRequest, HttpResponse } from '@
 import { delay } from 'rxjs/operators';
 import { Core } from './core';
 import { TestFactory } from './tests/factories/test-factory';
+import { async } from '@angular/core/testing';
 
 // @todo: create HttpHandlerMock class file and import it in tests to avoid duplication
 class HttpHandlerMock implements HttpHandler {
@@ -103,4 +104,23 @@ describe('Resource save', () => {
         expect(http_request_spy.calls.mostRecent().args[2].body.included.length).toBe(1);
         expect(http_request_spy.calls.mostRecent().args[2].body.included[0].id).toBe('author_1');
     });
+    it('should use POST if is_new is truthy', async () => {
+        let resource = TestFactory.getBook('book_1');
+        resource.is_new = true;
+        let http_request_spy = spyOn(HttpClient.prototype, 'request').and.callThrough();
+        test_response_subject.next(new HttpResponse({ body: TestFactory.getResourceDocumentData(Book) }));
+
+        await resource.save();
+        expect(http_request_spy.calls.mostRecent().args[0]).toBe('POST');
+    });
+
+    it('should use PATCH if is_new is falsy', async () => {
+        let resource = TestFactory.getBook('book_1');
+        resource.is_new = false;
+        let http_request_spy = spyOn(HttpClient.prototype, 'request').and.callThrough();
+        test_response_subject.next(new HttpResponse({ body: TestFactory.getResourceDocumentData(Book) }));
+
+        await resource.save();
+        expect(http_request_spy.calls.mostRecent().args[0]).toBe('PATCH');
+    });
 });

src/resource.spec.ts

@@ -40,7 +40,7 @@ describe('resource', () => {
             has_many_relationship: new DocumentCollection()
         };
         resource.links = {};
-        resource.is_new = true;
+        resource.is_new = false;
         resource.is_saving = false;
         resource.is_loading = false;
         resource.loaded = true;
@@ -339,7 +339,7 @@ describe('resource.save() method', () => {
                 meta: { some_data: 'some_data' }
             }
         };
-        expect(exec_spy).toHaveBeenCalledWith('1234', 'PATCH', expected_resource_in_save, true);
+        expect(exec_spy).toHaveBeenCalledWith('1234', 'POST', expected_resource_in_save, true);
     });
 
     it('top level meta object should be included in the request if available', async () => {
@@ -373,7 +373,7 @@ describe('resource.save() method', () => {
             },
             meta: { restore: true }
         };
-        expect(exec_spy).toHaveBeenCalledWith('1234', 'PATCH', expected_resource_in_save, true);
+        expect(exec_spy).toHaveBeenCalledWith('1234', 'POST', expected_resource_in_save, true);
     });
 
     it('restore method should set top level meta to restore the resource (according to Reyesoft specification extension)', async () => {
@@ -407,7 +407,7 @@ describe('resource.save() method', () => {
             },
             meta: { restore: true }
         };
-        expect(exec_spy).toHaveBeenCalledWith('1234', 'PATCH', expected_resource_in_save, true);
+        expect(exec_spy).toHaveBeenCalledWith('1234', 'POST', expected_resource_in_save, true);
     });
 
     // @todo fill from store to more new version of resource

src/resource.ts

@@ -303,7 +303,7 @@ export class Resource implements ICacheable {
             path.appendPath(this.id);
         }
 
-        Core.exec(path.get(), this.id ? 'PATCH' : 'POST', object, true).subscribe(
+        Core.exec(path.get(), this.is_new ? 'POST' : 'PATCH', object, true).subscribe(
             success => {
                 this.is_saving = false;