-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
closest for m/z - RT pair #20
Comments
hm, could be that I already implemented this somewhere (can't remember if it was in |
I don't know, could be that I missed it so far. But I think this is definitely something for MetaboCoreUtils. Can be used in MS1 annotation, alignment etc... |
Picking that issue up again: I would suggest the following definition: mclosest <- function(x, table, ppm = 0, tolerance = Inf) {
...
} where
Implementation suggestion:
The name would that be something you would be OK with @michaelwitting ? I could let Philippine @philouail implement that. |
Will this always match columns called |
I would require that both Examples:
does this make sense? |
Makes totally sense to me. |
@philouail implemented this now (PR #71). It's in the main branch and I'll push to Bioconductor. |
One thing I have to do quite often is to search for a specific m/z - RT pair in a data set. A function similar to
closest
would be great, but only returning the closest, but all matches. Maybe to be fit for the future already include the possibility of CCS values?What do you think @jorainer ?
The text was updated successfully, but these errors were encountered: