Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Mislabeling and Architecture Compatibility Issue in piper_macos_aarch64.tar.gz Package on M2 Mac #523

Open
kerbymart opened this issue Jun 13, 2024 · 1 comment · May be fixed by #678
Open

Comments

@kerbymart
Copy link

The piper executable included in the piper_macos_aarch64.tar.gz package seems to be compiled for x86_64 architecture instead of arm64, contrary to what the package name suggests. This has caused compatibility issues on an Apple M2 MacBook Pro running MacOS, specifically with the dependency libespeak-ng.1.dylib expecting an x86_64 version.

Steps to Reproduce

  1. Downloaded the piper_macos_aarch64.tar.gz package from [https://github.com/rhasspy/piper/releases/download/2023.11.14-2/piper_macos_aarch64.tar.gz].
  2. Extracted the package and executed piper.
kerby@Kerbys-MacBook-Pro piper % file /Users/kerby/Downloads/piper/piper    

/Users/kerby/Downloads/piper/piper: Mach-O 64-bit executable x86_64
@dharmab
Copy link

dharmab commented Dec 7, 2024

It looks like this might be happening because the GitHub actions workflow is only selecting the macos-latest runner. At the time of the last release, macos-latest pointed at macos-13, which was Intel x64. Therefore, both builds were running on AMD64.

In Feb 2024 macos-latest was updated to be an M1 mac runner, so if a release were to be repeated today with the same commit, it would likely have the opposite problem. The release labeld x64 would in fact be an ARM release.

@synesthesiam I think the macos job needs to be split up into two separate jobs. One should run on macos-13 and build the x64 release, and the other should run on macos-latest to build the aarch64 release.

@dharmab dharmab linked a pull request Dec 15, 2024 that will close this issue
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants