Add numFilesLimitHandler option so user can provide handler for busboy's filesLimit event
#253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jseppi
force-pushed
the
add-numFilesLimitHandler-option
branch
from
58ca337 to
441924a
Compare
|
Seems like an unrelated test is failing: https://travis-ci.com/github/richardgirges/express-fileupload/jobs/411601698#L315 It is also failing in this other PR https://github.com/richardgirges/express-fileupload/pull/244/commits that only fixes a typo: https://travis-ci.com/github/richardgirges/express-fileupload/jobs/379107787#L320 |
|
Ah, the test is failing in
https://travis-ci.com/github/richardgirges/express-fileupload |
|
Is there any plan to pick up this PR where it was left off? My current workaround (middleware to check the array length and throw an error) feels clunky, would be down to help with this issue. |
king-d-dev
approved these changes
Feb 19, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-attempt at #152.
It adds a new configuration option,
numFilesLimitHandler, so that the consumer can provide a handler function whenbusboy's'filesLimit'event is triggered. This event is triggered when the number of files uploaded surpasses the specificlimits.files.