fix(MulticastClient): catch and eat sender errors

richardschneider · Dec 16, 2018 · 400e1d0 · 400e1d0
1 parent 8ae7ae1
commit 400e1d0
Showing 1 changed file with 17 additions and 2 deletions.
diff --git a/src/MulticastClient.cs b/src/MulticastClient.cs
@@ -66,7 +66,6 @@ public MulticastClient(bool useIPv4, bool useIpv6, IEnumerable<NetworkInterface>
                 }
 
                 var localEndpoint = new IPEndPoint(address, MulticastPort);
-                log.Debug($"Will send to {localEndpoint}");
                 var sender = new UdpClient(address.AddressFamily);
                 try
                 {
@@ -89,6 +88,7 @@ public MulticastClient(bool useIPv4, bool useIpv6, IEnumerable<NetworkInterface>
                             throw new NotSupportedException($"Address family {address.AddressFamily}.");
                     }
 
+                    log.Debug($"Will send via {localEndpoint}");
                     if (!senders.TryAdd(address, sender)) // Should not fail
                     {
                         sender.Dispose();
@@ -115,7 +115,22 @@ public MulticastClient(bool useIPv4, bool useIpv6, IEnumerable<NetworkInterface>
 
         public async Task SendAsync(byte[] message)
         {
-            await Task.WhenAll(senders.Select(x => x.Value.SendAsync(message, message.Length, x.Key.AddressFamily == AddressFamily.InterNetwork ? MdnsEndpointIp4 : MdnsEndpointIp6))).ConfigureAwait(false);
+            foreach (var sender in senders)
+            {
+                try
+                {
+                    var endpoint = sender.Key.AddressFamily == AddressFamily.InterNetwork ? MdnsEndpointIp4 : MdnsEndpointIp6;
+                    await sender.Value.SendAsync(
+                        message, message.Length, 
+                        endpoint)
+                    .ConfigureAwait(false);
+                }
+                catch (Exception e)
+                {
+                    log.Error($"Sender {sender.Key} failure: {e.Message}");
+                    // eat it.
+                }
+            }
         }
 
         void Listen(UdpClient receiver)