Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Share common terraform variables #5

Open
msau42 opened this issue Jun 6, 2023 · 2 comments
Open

Share common terraform variables #5

msau42 opened this issue Jun 6, 2023 · 2 comments

Comments

@msau42
Copy link

msau42 commented Jun 6, 2023

For example, to use a non-default cluster name, I had to modify the variable in 4 different files.

Looks like terraform itself doesn't support global variables, but there may be a few workarounds:
https://stackoverflow.com/questions/51213871/terraform-provider-variable-sharing-in-modules

@richardsliu
Copy link
Owner

I think this should be fixed now (#3)

@msau42
Copy link
Author

msau42 commented Jun 7, 2023

Maybe some files need to be cleaned up, like https://github.com/richardsliu/ray-on-gke/blob/main/platform/modules/kuberay/variables.tf#L21?

I synced up to head yesterday and I found that one of the k8s manifests didn't get deployed. I changed the cluster_name reference in 4 files, but didn't check to see which ones still had the dependency.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants