Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Expression clones are expensive #271

Open
kalzoo opened this issue Aug 3, 2023 · 1 comment
Open

Expression clones are expensive #271

kalzoo opened this issue Aug 3, 2023 · 1 comment

Comments

@kalzoo
Copy link
Contributor

kalzoo commented Aug 3, 2023

In practice, expressions can be nested many layers deep, and this makes clone operations expensive enough to dominate compilation time. There are different ways we could make this cheaper:

  • Use of Arc instead of Box
  • An arena approach rather than a recursive struct
@kalzoo kalzoo changed the title Expression Clones are expensive Expression clones are expensive Aug 3, 2023
@genos
Copy link
Contributor

genos commented Aug 4, 2023

Very preliminary sketch of what the arena approach could look like:
Edit: see #274.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants