Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add support for Immutable dictionaries #351

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

TimothyMakkison
Copy link
Collaborator

@TimothyMakkison TimothyMakkison commented Apr 17, 2023

Resolve the last two types from #250

  • Added support for ImmutableDictionary and ImmutableSortedDictionary
  • Added guards to DictionaryMappingBuilder to prevent existing immutable types from being assigned to in a foreach loop. - I did not copy the approach of checking for a implicit setter from the Immutable Enumerable types as this would conflict with fix: Insert a cast to IDictionary when an explicit setter is present #341.
  • Added tests.

@TimothyMakkison TimothyMakkison marked this pull request as draft April 17, 2023 16:37
@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2023

Codecov Report

Merging #351 (76ae6aa) into main (dce4b42) will increase coverage by 0.37%.
The diff coverage is 92.54%.

❗ Current head 76ae6aa differs from pull request most recent head 6fed80e. Consider uploading reports for the commit 6fed80e to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
+ Coverage   91.71%   92.08%   +0.37%     
==========================================
  Files         109      122      +13     
  Lines        3379     3866     +487     
  Branches      438      526      +88     
==========================================
+ Hits         3099     3560     +461     
- Misses        189      207      +18     
- Partials       91       99       +8     
Impacted Files Coverage Δ
src/Riok.Mapperly.Abstractions/MapEnumAttribute.cs 100.00% <ø> (ø)
...berMappings/MemberNullDelegateAssignmentMapping.cs 57.14% <0.00%> (ø)
.../Mappings/NewInstanceObjectFactoryMemberMapping.cs 100.00% <ø> (ø)
...Mapperly/Descriptors/UserMethodMappingExtractor.cs 98.38% <50.00%> (ø)
...riptors/MappingBuilders/QueryableMappingBuilder.cs 68.42% <68.42%> (ø)
...Descriptors/Mappings/EnumFromStringParseMapping.cs 73.68% <73.68%> (ø)
...ptors/Mappings/MemberMappings/NullMemberMapping.cs 76.27% <76.27%> (ø)
src/Riok.Mapperly/Symbols/FieldMember.cs 78.57% <78.57%> (ø)
src/Riok.Mapperly/Symbols/PropertyMember.cs 78.57% <78.57%> (ø)
...lders/NewInstanceObjectMemberMappingBodyBuilder.cs 80.17% <80.17%> (ø)
... and 59 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@TimothyMakkison TimothyMakkison marked this pull request as ready for review April 17, 2023 17:31
Copy link
Contributor

@latonz latonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates!
Sorry for the late feedback. 2-3 smaller points to discuss / fix, otherwise it looks really good to me 😊
Could you then also rebase (I think there may be some conflicts 🤔) and squash into one feature commit? Thanks!

@TimothyMakkison TimothyMakkison force-pushed the linq_dict branch 2 times, most recently from 07cd05d to 96df8e1 Compare April 18, 2023 17:12
@latonz latonz merged commit 587abbc into riok:main Apr 18, 2023
@github-actions
Copy link

🎉 This PR is included in version 2.8.0-next.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants