-
-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
<application> does not work in iframe #6
Comments
This really needs to be done using the reverse proxy or the application itself. The X-Frame-Options header needs to exist, and set the value to something like, “ALLOW-FROM http://xxx.xx” in the HTTP response. If you're using Traefik, you will add a traefik flag - I'm using docker compose, and I have something like this (the last label is important):
In nginx, I think it's the site (or default) option proxy_hide_header X-Frame-Options; |
Just so people are aware, the directive allow-from from the header X-Frame-Options is obsolete. |
@mmarquezs thanks for the info, is there anything I need do on DashMachine's side? |
No, as you said this is something that requires a change on the original application or that can be fixed on the reverse proxy, So unless you add you own reverse proxy to DashMachines there is nothing to do. I just wanted to add the extra info just in case the other directive doesn't work for some browsers due to being obsolete. |
You will notice that DashMachine's iframe option only works with certain apps. Here is the explanation: https://stackoverflow.com/questions/6663244/cant-show-some-websites-in-iframe-tag
If someone finds out a way around this, please let me know or submit a PR.
The text was updated successfully, but these errors were encountered: