Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[💡 FEATURE REQUEST]: Increase error message length #1127

Closed
ykweb opened this issue May 11, 2022 · 2 comments · Fixed by roadrunner-server/goridge#177
Closed

[💡 FEATURE REQUEST]: Increase error message length #1127

ykweb opened this issue May 11, 2022 · 2 comments · Fixed by roadrunner-server/goridge#177
Assignees
Labels
C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Milestone

Comments

@ykweb
Copy link

ykweb commented May 11, 2022

Plugin

Logger

I have an idea!

Encountered an error creating php worker
But the length of the message does not allow us to understand what the error is.
{"level":"ERROR","ts":"2022-05-11T15:38:15.012+0300","logger":"jobs ","msg":"job execute failed","error":"goridge_frame_receive: CRC verification failed, bad header: TypeError {#209\n"}

The full message looked like this:
TypeError {#209 #message: "Symfony\Component\Console\Application::__construct(): Argument #1 ($name) must be of type string, App\Kernel given, called in /app/bin/jobs on line 17" #code: 0 #file: "./vendor/symfony/console/Application.php" #line: 91 trace: {

@ykweb ykweb added the C-feature-request Category: feature requested, but need to be discussed label May 11, 2022
@rustatian
Copy link
Member

Hey @ykweb 👋🏻 . Thanks for the contribution. I'll try to find a way to show an entire error message during the worker boot-up.

@rustatian rustatian moved this to Backlog in General May 11, 2022
@rustatian rustatian added C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. and removed C-feature-request Category: feature requested, but need to be discussed labels May 11, 2022
@rustatian rustatian moved this from Backlog to Todo in General May 11, 2022
@rustatian rustatian added this to the v2.12.0 milestone May 11, 2022
@rustatian
Copy link
Member

Source: https://github.com/roadrunner-server/goridge/blob/master/internal/receive.go#L53

@rustatian rustatian moved this from Todo to In Progress in General May 25, 2022
@rustatian rustatian modified the milestones: v2.12.0, v2.10.2 May 25, 2022
Repository owner moved this from In Progress to Unreleased in General May 25, 2022
@rustatian rustatian moved this from Unreleased to Done in General May 26, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants