Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Determine whether door_return actually drops anything #6

Open
robertdfrench opened this issue Jun 8, 2021 · 2 comments
Open

Determine whether door_return actually drops anything #6

robertdfrench opened this issue Jun 8, 2021 · 2 comments
Labels
unclear Further information is requested

Comments

@robertdfrench
Copy link
Owner

robertdfrench commented Jun 8, 2021

The definition of door_return given in src/illumos/door_h.rs indicates that door_return never returns to the calling thread. This should be enough to persuade rustc to Drop anything that needs dropping, right? Or wrong?

@robertdfrench
Copy link
Owner Author

This will help figure out whether the demo applications encourage people to leak memeory

@robertdfrench
Copy link
Owner Author

Does not seem to drop everything -- there seems to be a constant amount of memory leaked per door invocation in the examples. I think that the buffers passed to door_return are allocated anew on each door_call, and then never deallocated. Need to confirm this, but if it's the case, then might want to have a reserved buffer for "return data", or some way (egads) deallocating the previously used buffer on subsequent door invocations.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
unclear Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant