fix: Store the value of the boolean literals in the AST

Author: robertoraggi

src/frontend/cxx/ast_printer.cc

@@ -610,6 +610,10 @@ void ASTPrinter::visit(CharLiteralExpressionAST* ast) {
 
 void ASTPrinter::visit(BoolLiteralExpressionAST* ast) {
   fmt::print(out_, "{}\n", "bool-literal-expression");
+  ++indent_;
+  fmt::print(out_, "{:{}}", "", indent_ * 2);
+  fmt::print(out_, "value: {}\n", ast->value);
+  --indent_;
 }
 
 void ASTPrinter::visit(IntLiteralExpressionAST* ast) {

src/parser/cxx/ast.fbs

@@ -760,7 +760,6 @@ table CharLiteralExpression /* ExpressionAST */ {
 }
 
 table BoolLiteralExpression /* ExpressionAST */ {
-  literal: uint32;
   literal_loc: SourceLocation;
 }
 

src/parser/cxx/ast.h

@@ -1021,7 +1021,7 @@ class BoolLiteralExpressionAST final : public ExpressionAST {
   BoolLiteralExpressionAST() : ExpressionAST(ASTKind::BoolLiteralExpression) {}
 
   SourceLocation literalLoc;
-  TokenKind literal = TokenKind::T_EOF_SYMBOL;
+  bool value = false;
 
   void accept(ASTVisitor* visitor) override { visitor->visit(this); }
 

src/parser/cxx/ast_cloner.cc

@@ -1008,7 +1008,7 @@ void ASTCloner::visit(BoolLiteralExpressionAST* ast) {
 
   copy->literalLoc = ast->literalLoc;
 
-  copy->literal = ast->literal;
+  copy->value = ast->value;
 }
 
 void ASTCloner::visit(IntLiteralExpressionAST* ast) {

src/parser/cxx/ast_decoder.cc

@@ -1499,7 +1499,6 @@ auto ASTDecoder::decodeBoolLiteralExpression(
   if (!node) return nullptr;
 
   auto ast = new (pool_) BoolLiteralExpressionAST();
-  ast->literal = static_cast<TokenKind>(node->literal());
   return ast;
 }
 

src/parser/cxx/ast_encoder.cc

@@ -1702,7 +1702,6 @@ void ASTEncoder::visit(BoolLiteralExpressionAST* ast) {
 
   io::BoolLiteralExpression::Builder builder{fbb_};
   builder.add_literal_loc(literalLoc.o);
-  builder.add_literal(static_cast<std::uint32_t>(ast->literal));
 
   offset_ = builder.Finish().Union();
   type_ = io::Expression_BoolLiteralExpression;

src/parser/cxx/parser.cc

@@ -382,8 +382,10 @@ auto Parser::parse_literal(ExpressionAST*& yyast) -> bool {
       auto ast = new (pool) BoolLiteralExpressionAST();
       yyast = ast;
 
+      const auto value = LA().is(TokenKind::T_TRUE);
+
       ast->literalLoc = consumeToken();
-      ast->literal = unit->tokenKind(ast->literalLoc);
+      ast->value = value;
 
       return true;
     }

tests/unit_tests/ast/bool_literals_01.cc

@@ -0,0 +1,33 @@
+// RUN: %cxx -verify -ast-dump %s | %filecheck %s --match-full-lines
+
+const bool ok = true;
+const bool ko = false;
+
+//      CHECK:translation-unit
+// CHECK-NEXT:  declaration-list
+// CHECK-NEXT:    simple-declaration
+// CHECK-NEXT:      decl-specifier-list
+// CHECK-NEXT:        const-qualifier
+// CHECK-NEXT:        integral-type-specifier
+// CHECK-NEXT:      init-declarator-list
+// CHECK-NEXT:        init-declarator
+// CHECK-NEXT:          declarator: declarator
+// CHECK-NEXT:            core-declarator: id-declarator
+// CHECK-NEXT:              name: simple-name
+// CHECK-NEXT:                identifier: ok
+// CHECK-NEXT:          initializer: equal-initializer
+// CHECK-NEXT:            expression: bool-literal-expression
+// CHECK-NEXT:                value: true
+// CHECK-NEXT:    simple-declaration
+// CHECK-NEXT:      decl-specifier-list
+// CHECK-NEXT:        const-qualifier
+// CHECK-NEXT:        integral-type-specifier
+// CHECK-NEXT:      init-declarator-list
+// CHECK-NEXT:        init-declarator
+// CHECK-NEXT:          declarator: declarator
+// CHECK-NEXT:            core-declarator: id-declarator
+// CHECK-NEXT:              name: simple-name
+// CHECK-NEXT:                identifier: ko
+// CHECK-NEXT:          initializer: equal-initializer
+// CHECK-NEXT:            expression: bool-literal-expression
+// CHECK-NEXT:                value: false