Buiding error in Android 10 due to commit 07176f0

[maurossi]

Hi @rsglobal

After testing the build of gbm_gralloc starting from Android 9 to Android 12
I found that Android 10 is the only version affected by the following building error:

FAILED: 
build/make/core/base_rules.mk:526: error: overriding commands for target `out/target/product/x86_64/system/vendor/etc/vintf/manifest/gbm_gralloc_manifest.xml', previously defined at build/make/core/base_rules.mk:526
20:37:32 ckati failed with: exit status 1

#### failed to build some targets (02:00 (mm:ss)) ####

As a proposal, is it acceptable for everyone to use LOCAL_VINTF_FRAGMENTS := gbm_gralloc_manifest.xml for Android 11 and later?

[maurossi]

Proposed patch in the attachment, tested and it works

0001-Use-manifest-fragment-with-Android-11-and-later.txt

[rsglobal]

Hi @maurossi ,

Merging fragmented manifest here wasn't a good idea despite it was mine MR.
As for today I would prefer somainline approach: https://github.com/SoMainline/android-lights-hal/blob/aosp-12.0/lights.mk

[maurossi]

Hi @rsglobal

Do you prefer to revert commit 07176f0 ?
Thanks for the feedback

[rsglobal]

Yes, I think reverting it would be better option.

[maurossi]

Thanks Roman,

@robherring could you please proceed with the revert of commit 07176f0 ?

Thank you

[robherring]

@maurossi Can you make a PR with the revert please.

[maurossi]

Hello,

Pull Request #29 was created

[MarijnS95]

Instead of plainly reverting it'd be great if an alternative easy-to-use solution could have been provided (like mine that you linked from the SoMainline repo above). I'm now greeted with:

checkvintf I 09-19 23:39:24   271   271 check_vintf.cpp:424] Skip checking unused HALs.
checkvintf E 09-19 23:39:24   271   271 check_vintf.cpp:554] files are incompatible: Device manifest and framework compatibility matrix are incompatible: HALs incompatible. Matrix level = 4. Manifest level = 4. The following requirements are not met:
checkvintf E 09-19 23:39:24   271   271 check_vintf.cpp:554] android.hardware.graphics.allocator:
checkvintf E 09-19 23:39:24   271   271 check_vintf.cpp:554]     required:
checkvintf E 09-19 23:39:24   271   271 check_vintf.cpp:554]         @2.0::IAllocator/default OR
checkvintf E 09-19 23:39:24   271   271 check_vintf.cpp:554]         @3.0::IAllocator/default OR
checkvintf E 09-19 23:39:24   271   271 check_vintf.cpp:554]         @4.0::IAllocator/default
checkvintf E 09-19 23:39:24   271   271 check_vintf.cpp:554]     provided:
checkvintf E 09-19 23:39:24   271   271 check_vintf.cpp:554] android.hardware.graphics.mapper:
checkvintf E 09-19 23:39:24   271   271 check_vintf.cpp:554]     required:
checkvintf E 09-19 23:39:24   271   271 check_vintf.cpp:554]         @2.1::IMapper/default OR
checkvintf E 09-19 23:39:24   271   271 check_vintf.cpp:554]         @3.0::IMapper/default OR
checkvintf E 09-19 23:39:24   271   271 check_vintf.cpp:554]         @4.0::IMapper/default
checkvintf E 09-19 23:39:24   271   271 check_vintf.cpp:554]     provided:
checkvintf E 09-19 23:39:24   271   271 check_vintf.cpp:554] : Success

As I had come to rely on gbm_gralloc providing its own manifest the way it's intended to.

[maurossi]

Hi @MarijnS95

What Android version is producing the log?

Is there a way to allow building gbm_gralloc also in Android 7, 8, 9, 10 which are still active branches in android-x86 project?

[MarijnS95]

@maurossi This was Android 11.