You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We received an interesting issue for lychee here: lycheeverse/lychee#604.
The gist is that links with wildcard operators (e.g. https://*.example.com) get properly extracted by linkify, but we cannot easily check them with lychee.
We now wonder if we should handle the exclusion of such wildcard URLs on our end or whether it's better to discard them right away with linkify.
From my perspective, these are valid links, so linkify is correct, but the behavior might be surprising to downstream users. Perhaps another config option could be introduced which would allow to skip such wildcard URLs:
let finder = LinkFinder::new().wildcards(false);
However there are other sub-delimiters, so I could understand if such cases won't be handled by linkify. In this scenario we would filter them in lychee instead.
The text was updated successfully, but these errors were encountered:
We received an interesting issue for lychee here: lycheeverse/lychee#604.
The gist is that links with wildcard operators (e.g. https://*.example.com) get properly extracted by linkify, but we cannot easily check them with lychee.
We now wonder if we should handle the exclusion of such wildcard URLs on our end or whether it's better to discard them right away with linkify.
From my perspective, these are valid links, so linkify is correct, but the behavior might be surprising to downstream users. Perhaps another config option could be introduced which would allow to skip such wildcard URLs:
However there are other sub-delimiters, so I could understand if such cases won't be handled by linkify. In this scenario we would filter them in lychee instead.
The text was updated successfully, but these errors were encountered: