Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

A little suggestion about the code #7

Open
Nineteen-Hundred opened this issue May 24, 2019 · 3 comments
Open

A little suggestion about the code #7

Nineteen-Hundred opened this issue May 24, 2019 · 3 comments

Comments

@Nineteen-Hundred
Copy link

Nineteen-Hundred commented May 24, 2019

When I directly call the PUCCH_encoder.m and PUCCH_decoder.m, only 15 (32,16) polar blocks can be encoded or decoded per second. After reading the code, I have found an interesting point that the path 'component' will be added every time the encoding and decoding function is called. After moving the corresponding codes to top file to make them be called only once, the speed can be improved by up to 100 times (about 2000 blocks per second). So, I think this may be taken into consideration in your future revision.

@robmaunder
Copy link
Owner

Thanks for this excellent suggestion! I will incorporate it into a future version.

@zpan008
Copy link

zpan008 commented Feb 23, 2022

@robmaunder If folder 'components' is renamed to 'private', then all the instances of addpath 'components' in the code can be removed.

@robmaunder
Copy link
Owner

@robmaunder If folder 'components' is renamed to 'private', then all the instances of addpath 'components' in the code can be removed.

Another excellent suggestion! I will incorporate it into a future version.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants