Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for StrimziPodSets #372

Open
sappusaketh opened this issue Dec 5, 2024 · 1 comment · May be fixed by #388
Open

Add support for StrimziPodSets #372

sappusaketh opened this issue Dec 5, 2024 · 1 comment · May be fixed by #388

Comments

@sappusaketh
Copy link

sappusaketh commented Dec 5, 2024

Is your feature request related to a problem? Please describe.
Unable to get resource recommendations for pods created using StrimziPodSets crd. I tried using --selector but still unable to get recommendations

I get correct response from
k get pod -n <my-ns> -l key=value

krr simple -p myprometheus.com --selector "key=value" -n <my-ns>
returns

WARNING  Current filters resulted in no objects available to scan.                                                   runner.py:300
WARNING  Try to change the filters or check if there is anything available.                                          runner.py:301

Describe the solution you'd like
Get resource recommendations for pods created by StrimziPodSets

Describe alternatives you've considered
I haven't found any yet

Are you interested in contributing a PR for this?
Yes

Additional context
I have found this? part of code but unclear whether it will work only on these types resources or all

@aantn
Copy link
Contributor

aantn commented Dec 8, 2024

Hi @sappusaketh, you'll have to add some code like the 2nd link you referenced. You can use the function _list_rollouts as reference, which adds support to KRR for ArgoRollouts.

@sappusaketh sappusaketh linked a pull request Jan 1, 2025 that will close this issue
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants