Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

unpermitted_parameters logging? #152

Closed
aripollak opened this issue Nov 17, 2015 · 1 comment
Closed

unpermitted_parameters logging? #152

aripollak opened this issue Nov 17, 2015 · 1 comment

Comments

@aripollak
Copy link
Contributor

When config.action_controller.action_on_unpermitted_parameters = :log is set, Rails 4 can emit an "unpermitted_parameters.action_controller" event, which is normally handled by the default LogSubscriber, but lograge uses its own subscriber so the unpermitted parameters never got logged. Would it make sense for lograge to handle that event and add it to the log line automatically if it's set? By default the action_on_unpermitted_parameters config is unset so it would never show up in the log, but if you've explicitly set that config, it would.

@pxlpnk
Copy link
Collaborator

pxlpnk commented Nov 20, 2015

I like this idea.
A PR is very welcome. 👯 so we have a base for discussion.

The default behaviour should be off I think. And people can enable it when they need it.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants