From ab3f45d07f4501f7d97f34865cf6f1938783522d Mon Sep 17 00:00:00 2001
From: Kieran <kieran.brahney@gmail.com>
Date: Sun, 8 Oct 2023 20:15:15 +0100
Subject: [PATCH] fix(node-resolve): modulePaths default is not set (#1534)

* fix(node-resolve): modulePaths default is not set

* test: add a test for defaults

---------

Co-authored-by: shellscape <andrew@shellscape.org>
---
 packages/node-resolve/src/index.js            |   1 +
 .../node-resolve/test/snapshots/test.mjs.md   |  21 ++++++++++++++++++
 .../node-resolve/test/snapshots/test.mjs.snap | Bin 823 -> 1077 bytes
 packages/node-resolve/test/test.mjs           |   6 ++++-
 4 files changed, 27 insertions(+), 1 deletion(-)

diff --git a/packages/node-resolve/src/index.js b/packages/node-resolve/src/index.js
index 09ce84cd8..3d389383d 100644
--- a/packages/node-resolve/src/index.js
+++ b/packages/node-resolve/src/index.js
@@ -37,6 +37,7 @@ const defaults = {
   extensions: ['.mjs', '.js', '.json', '.node'],
   resolveOnly: [],
   moduleDirectories: ['node_modules'],
+  modulePaths: [],
   ignoreSideEffectsForRoot: false,
   // TODO: set to false in next major release or remove
   allowExportsFolderMapping: true
diff --git a/packages/node-resolve/test/snapshots/test.mjs.md b/packages/node-resolve/test/snapshots/test.mjs.md
index 7eccb2357..ab64d89de 100644
--- a/packages/node-resolve/test/snapshots/test.mjs.md
+++ b/packages/node-resolve/test/snapshots/test.mjs.md
@@ -4,6 +4,27 @@ The actual snapshot is saved in `test.mjs.snap`.
 
 Generated by [AVA](https://avajs.dev).
 
+## has default config
+
+> Snapshot 1
+
+    {
+      allowExportsFolderMapping: true,
+      dedupe: [],
+      extensions: [
+        '.mjs',
+        '.js',
+        '.json',
+        '.node',
+      ],
+      ignoreSideEffectsForRoot: false,
+      moduleDirectories: [
+        'node_modules',
+      ],
+      modulePaths: [],
+      resolveOnly: [],
+    }
+
 ## throws error if local id is not resolved
 
 > Snapshot 1
diff --git a/packages/node-resolve/test/snapshots/test.mjs.snap b/packages/node-resolve/test/snapshots/test.mjs.snap
index 84c150452384f0b6ee8303f0be5c734a9d30e0a6..e8af19cf355b7af30cfc13e11c3659c7c76ce39b 100644
GIT binary patch
literal 1077
zcmV-51j_qCRzV<BZeeh9Xm4~Nb~6eC0Bf+gQBNhUhZ~U(_;FmFlVH9dY+0B6Qb^YO
z@2H5|r5}q300000000Bcm(6e7L=?b1-j7sm=_V>d<-{l_4#^@RB&5=+G|h*C+B8b3
zT29@GJzh_CJY#0Y-K@lg0|#y#IC3d}0OG#@DiA{A&H;%Ne+188`{AwIbyzEn^knDF
zdo$0!_n!UsnRm>kGtl3BPYpAiDxYZVQjbL3U`Gm%^_dnV)V?(O%V(}j4EfCNH>?#a
z{zDhgg<ZJb1^EKxTaX_?{sOU)WxWG(6}8t;`~L9>bqqq|+tt-o3%y~X6$^F1#(onu
zEYw;<ZxhbtaOX6X%IICmU8?SpFl3^iSlAs4T|wvuY@B<vUFt?5P4tha^cU%=p+Yk$
zbm5F^tS_XZ5131LJP(3_gVd3fCOu*`+3M@5t=0nRMx1Ul1;$b_suPnRrc5rSCWplM
z>EiS0MMbsbPw9QZM*uBl(z>k_86i8r>vTFX(AGcT_%8^uE$c0iP1~ArXcQdmZ7}$x
zVAPy7nptbTWUW23cF{sj3tf)cji0624Ni2XL@3ubx)bG?a|@JG<m$#mEu>46-BEG(
z%kk2al%>v!^7LKfD>>AdDkT+W9)_AF95WX)jfFHg!|Tq~>f^0(skW>&^uZk&ad+AU
zuXo?`q+G|Ik^x?iM84H#at1uWdLG4LQkfb%kv3pER}y&0jE_0(6K9ke9c5_`O<aZD
zS(nj#XQ5!Kv+NDHzHiOu6&3RX1TR59<W9{2Tt5f-4rHs?e)e4ZH43fKbbx>U&y~Zw
z5BK&Do;<pJbg+N0S1?@(sMe&PTiah*aqc!VfY<S-KE=I7IP|bg7I6IXIi^&=8z_V|
zVyN524>fEv2fMd{hdy(B9KZqKgo(f;=F%-h*$#QsXJV$l@)+~X?#$Ge2cl>op$J}_
zMu<&Q^^`ss1)Pb2&cdHBzQ4!WyoT%#;d(R4X58^R@lk1FliMV*$z7fqR1x=!Q5R$F
zr7Z&;B>Ggv)Y9O)_z?yD5EDKmBaI`VZXkh5avp`aH@{EjmovOkjo~rT(5|W!-7htw
zLwpf(S%l@l_B}k35f&7l(fCYn;E+>r0s|;vFl1Us^sInF;tU|<*BDS1;nD!zss?EC
zbuVS~Yn_bbB8(<ME)COOHB3x6JaXwBn0M}_U)54vf7Xd>xCpNKV3&sNW;JYz5_gyJ
z^8R~XC#+x*Sb2y`L-bL_%F-_d^mCnn1`Ab_UMilCtKu0CIHin!tCLZ<7^A5%?A%(7
zhw!uM^=`E!#HAtHI@2%!<!osA%=CMmoK%I8AdU0927@?JuOM~)gTW-orD3{W9aH%%
v@Kc?HP8KD!ywCsknHp{%@<ZU=Sc>V7Ix(3FEtg07zk&S+)>4ha5)=Rc94HQF

literal 823
zcmV-71IYYARzV<BZeeh9Xm4~Nb~6eC06?<Au(HK8t+^i=z{n^azAz5DpOy=^v#1)m
z^aA^H1s{tD00000000BcmP>EbKoG~h=?n2nD>!f*<;0;45<)_PR?rt!BxtKbRXCB2
zy@|J3d(G~;X^tE?^98t+FT+D1gv2-Ci!gTL^pP6u60420+I4nj_n+U)ICIc!2x+(V
z`;W|UBiR0J<0{$Fz?6~-coT4&3g8ZK4Zbv>n3iIXIb8cR(5^K4?SbP^Ltie9SyNW@
zArsaNxwkAs;T&~=O7%`t$_g}<^q>;@$x(Ch9o1c3NmOi7AtDuas14eB(g_7y;fmQt
zD$X=?xN$+S7PY&5qpjXy8-d}{*VW@L-66HFh&PaXiIiq>zKi1qnVcaLi%QWhA<3#-
zE?eZXMTkYN5Hg=Qjkj@rgX05^CDM1E+-U6Louo8aPESu;<eEjsEK)|B(#>c!F+;{}
z>9FMC`sUN^wc7gYoyD#7+WOiF(<zT>O<Rd|>7C`H?_3|?19;&wsAu6&2N`dGOEokY
z^TA;O?oq>>Dr{>!W(anD7CJ7sUGVS%bOP!Fjkr`#sGJN$*y4Wjc=f2pB(kf=@~eqM
zF;8L=oE}EhrkUDf&%2)Bep~nD4=3O6K{RiX(tVs4;%H(NCRU@XdV!6XabV+B5*d;c
z_vxrlYOVK51}n&KF%?nkiLb&A!|yvlMTd4Zgh<_B0F@LX44^)IPTwzKIG>MUgK8{S
zm5T05f#`_HLawhc9ayaiT^WMU@HZNl>sbf{Lnk!A6h=d?b;!;ND4=#5C0}4beT5?f
z^e7)7wr`lPqh%_iZ$&baSr{FP92usye3-azi_l@qQn6?8OEewVuOe}EvfvsPJ2Gqw
z`LHQQohMwR*WcG7VR>0#B@#!5=wZ&x(tic?xky0mOxdJIisx}&Jc9-&mC^Si83oxG
z9cjbPt<*$7v30)Cr4~yZ8KR{#H3OK=hNbsRKZ@j}a<l|Jo#)jUM1lGTsq=3P4n>X(
z(}Vn&(tCkVMH1T0N@#R{|0`!IxEjWX;=3^w)6XI?nH(jTDE)6>e*oHta4LNf002y%
Bh4}yg

diff --git a/packages/node-resolve/test/test.mjs b/packages/node-resolve/test/test.mjs
index 9318d4ea4..64cabc347 100755
--- a/packages/node-resolve/test/test.mjs
+++ b/packages/node-resolve/test/test.mjs
@@ -6,7 +6,7 @@ import commonjs from '@rollup/plugin-commonjs';
 import test from 'ava';
 import { rollup } from 'rollup';
 
-import { nodeResolve } from 'current-package';
+import { nodeResolve, DEFAULTS } from 'current-package';
 
 import { evaluateBundle, getCode, getImports, testBundle } from '../../../util/test.js';
 
@@ -23,6 +23,10 @@ test('exposes plugin version', (t) => {
   t.regex(plugin.version, /^\d+\.\d+\.\d+/);
 });
 
+test('has default config', (t) => {
+  t.snapshot(DEFAULTS);
+});
+
 test('finds a module with jsnext:main', async (t) => {
   const bundle = await rollup({
     input: 'jsnext.js',