Skip to content
This repository was archived by the owner on Aug 4, 2021. It is now read-only.

Browser option error #128

Closed
Antonio-Laguna opened this issue Jan 10, 2018 · 1 comment
Closed

Browser option error #128

Antonio-Laguna opened this issue Jan 10, 2018 · 1 comment

Comments

@Antonio-Laguna
Copy link

Hey here,

It seems 3.0.1 introduces a regression on this plugin regarding the browser option. One of the checks is like this:

else if (options.browser && pkg[ 'browser' ][ pkg[ 'main' ] ]) {

Which looks rather unsafe to me. If for some reason pkg['browser'] is not there, this just blows as it can read property of undefined. Was this intentional? Am I doing something wrong? Or is this a legit bug?

Kind to submit a PR to make that if a tad safer.

@Antonio-Laguna
Copy link
Author

#129 seems like it fixed it.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant