This repository has been archived by the owner on Aug 4, 2021. It is now read-only.
Provide a dedicated typescript typings file #58
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #50
Even though this package had
typings
defined in its package.json file (that linked to the source folder), I never got these to work for me. This PR adopts the approach followed by Rollup that maintains a hand-crafted file for its external types that is used internally as well to ensure consistency. In my experiments, this now works very well.Another advantage is that there no longer is a reason to publish the sources with the package. I still kept them in as removing them would be a breaking change but this is something I would recommend for the next major version.
Feedback welcome.