Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

🩹 Only prioritize block templates in block themes #368

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

Log1x
Copy link
Member

@Log1x Log1x commented Mar 30, 2024

Block templates should only be prioritized when there is a index.html (see: https://developer.wordpress.org/reference/classes/wp_theme/is_block_theme/)

Fixes potential issues like https://discourse.roots.io/t/acorn-v4-1-1-released/26905/2

@Log1x
Copy link
Member Author

Log1x commented Mar 30, 2024

Looking back at the code on #314 in light of the issue reported above, things make a little more sense to me now.

I have reimplemented @dsturm's original approach. Apologies for the oversight.

@QWp6t QWp6t merged commit 5e80f30 into main Apr 2, 2024
2 checks passed
@QWp6t QWp6t deleted the fix/custom-page-templates branch April 2, 2024 14:26
QWp6t pushed a commit that referenced this pull request Apr 2, 2024
---------

Co-authored-by: Daniel Sturm <384815+dsturm@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants