Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

🐛 Fix i18n warnings #3039

Merged
merged 1 commit into from
May 11, 2022
Merged

🐛 Fix i18n warnings #3039

merged 1 commit into from
May 11, 2022

Conversation

strarsis
Copy link
Contributor

@strarsis strarsis commented May 11, 2022

This PR fixes the i18n warnings by adding a missing translators comment and uses a singular placeholder.
For single comments, One is used instead of a number (in a comments title context), which fixes the 2nd i18n warning.

Edit: Fixed something and merged commits into one, hence the force-pushes...

@github-actions github-actions bot added php Pull requests that update PHP code views labels May 11, 2022
@strarsis strarsis mentioned this pull request May 11, 2022
4 tasks
@strarsis strarsis force-pushed the fix-i18n-warnings branch from a09aae0 to a98e089 Compare May 11, 2022 19:12
Add singular placeholder.
@strarsis strarsis force-pushed the fix-i18n-warnings branch from a98e089 to 04d4fce Compare May 11, 2022 19:14
Copy link
Member

@retlehs retlehs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@retlehs retlehs changed the title Fix i18n warnings 🐛 Fix i18n warnings May 11, 2022
@retlehs retlehs merged commit 0392176 into roots:main May 11, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
php Pull requests that update PHP code views
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants