Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

rOpenSci submission notes #57

Closed
8 of 9 tasks
mdsumner opened this issue Dec 12, 2017 · 4 comments
Closed
8 of 9 tasks

rOpenSci submission notes #57

mdsumner opened this issue Dec 12, 2017 · 4 comments
Labels
v0.0.4 post ROpenSci review

Comments

@mdsumner
Copy link
Collaborator

mdsumner commented Dec 12, 2017

  • questions on activate, is it generic, separate var/grids?
  • set up links to files we understand, some examples of other weird sources (see mdsumner/rasterwise)
  • clarify relation to rerddap
  • need a vignette
  • do check, and report on exceptions
  • check https://github.com/ropensci/onboarding/blob/master/packaging_guide.md
  • remove all raady ness
  • fix appveyor
  • insert install instructions (copy anglr plan)
@mdsumner
Copy link
Collaborator Author

mdsumner commented Feb 9, 2018

names of thingies

I'm considering updating the name situation like this

  • hyper_filter -> filter.tidync
  • hyper_slice -> hyper_array
  • hyper_tibble -> as_tibble.tidync
  • hyper_tbl_cube -> as_tbl_cube
  • activate -> ??

It's a bit incongruous for filter, given that the syntax is special for expressions lon = lon > 10 but I think that might be ok.

Is it ok that filter.tidync returns a tidync object, rather than a tibble? If that were ok then also slice is exactly right - and we can forget hyper_slice/hyper_array.

I'm also toying with select for activating a grid or variable/s
activate I just don't know

@mdsumner
Copy link
Collaborator Author

The l3m file is not super useful as it has only 11 valid pixels, so it works fine and is small but doesn't look like it works.

@mdsumner
Copy link
Collaborator Author

Ooh, try this:

  • hyper_index(1:4, 4:12, 5:8, ...) ## for raw slice versions of hyper_filter
  • hyper_axes(tidync) ## to strip out the selected axis_transforms, to match hyper_slice output

Use this to construct as_tbl_cube (general) and as.RasterLayer (slice-limited) examples. The examples can make it clear that the rectilinear case fits perfectly, and even when degenerate the affine case is ignored, and the curvlinear case is just coordinates as variables, the axes are index-only. This inspired by the rerddap discussion on "melting".

@mdsumner mdsumner added the v0.0.4 post ROpenSci review label Mar 6, 2018
@mdsumner
Copy link
Collaborator Author

I consider this ok now

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
v0.0.4 post ROpenSci review
Projects
None yet
Development

No branches or pull requests

1 participant