Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix AttributeError with docutils >= 0.18 #352

Merged

Conversation

onjen
Copy link
Contributor

@onjen onjen commented Jan 30, 2023

Closes #351

@cottsay
Copy link
Member

cottsay commented Sep 12, 2023

Is this change backwards compatible with older docutils versions?

@onjen
Copy link
Contributor Author

onjen commented Sep 13, 2023

I just tested with docutils==0.16.0 and it works.

Also the release notes state that the text is already in the node and there is no need to access the rawsource attribute.

nodes.Text.rawsource: we store the null-escaped text in Text nodes since 0.16 so there is no additional information in the rawsource.

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Copy link
Member

@cottsay cottsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested with some older docutils versions and added tests to prove it works with the newer ones as well.

@cottsay cottsay merged commit eec17e7 into ros-infrastructure:master Jan 9, 2025
18 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attribute Error with docutils 0.19
3 participants