Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

remove GetConstraintAwarePositionIK.srv #4

Closed
isucan opened this issue Feb 8, 2013 · 3 comments
Closed

remove GetConstraintAwarePositionIK.srv #4

isucan opened this issue Feb 8, 2013 · 3 comments
Assignees
@sachinchitta

Comments

@isucan
Copy link
Contributor

isucan commented Feb 8, 2013

It does not make sense to me to have two almost identical services. I have added a flag for collision checking and a Constraints message to the regular IK request (this costs just a few bytes (i believe 8 bytes) in the request) and an if statement in the implementation. It makes life easier for implementing things and also to call things.
The only code that uses that service is kinematics_constraint_aware
@ghost ghost assigned sachinchitta Feb 8, 2013
@awesomebytes
Copy link

I got a bit confused finding this .srv. If it's actually not used anywhere it may not be necessary.

@davetcoleman davetcoleman mentioned this issue Nov 15, 2016
Closed
davetcoleman added a commit to davetcoleman/moveit_msgs that referenced this issue Nov 15, 2016
@davetcoleman
Removed identical services per issue moveit#4 and unused service from…
9fbc3bb 
… issue moveit#4
@davetcoleman davetcoleman mentioned this issue Nov 15, 2016
Merged
davetcoleman added a commit to davetcoleman/moveit_msgs that referenced this issue Nov 16, 2016
@davetcoleman
Removed identical services per issue moveit#4 and unused service from…
2f3f97b 
… issue moveit#4
130s added a commit that referenced this issue Nov 17, 2016
@130s
Merge pull request #35 from davetcoleman/remove_old_services
cf3a83e 
Removed identical services per issue #4 and unused service from issue #4
@130s
Copy link
Contributor

130s commented Nov 17, 2016

Addressed for Kinetic in #35

@davetcoleman
Copy link
Member

Only took 3 years ⏳

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@sachinchitta sachinchitta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@davetcoleman @isucan @awesomebytes @130s @sachinchitta