Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

change serialization to use uint8_t instead of char #19

Open
Karsten1987 opened this issue Mar 27, 2020 · 0 comments
Open

change serialization to use uint8_t instead of char #19

Karsten1987 opened this issue Mar 27, 2020 · 0 comments
Assignees
@Karsten1987
Labels
enhancement New feature or request

Comments

@Karsten1987
Copy link
Collaborator

The serialization payload should really be serialized with uin8_t instead of char to guarantee a consistent size of 8bit on all platforms.
See here: https://github.com/ros2/rmw_iceoryx/blob/master/rmw_iceoryx_cpp/include/rmw_iceoryx_cpp/iceoryx_serialize.hpp#L33
@Karsten1987 Karsten1987 added the enhancement New feature or request label Mar 27, 2020
@Karsten1987 Karsten1987 self-assigned this Mar 27, 2020
@Karsten1987 Karsten1987 mentioned this issue Mar 27, 2020
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@Karsten1987 Karsten1987

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Karsten1987