Skip to content

Commit f5af6d5

Browse files
committed
Separate generators from generatED files
@michaeldgraham according to `git blame` you wrote most of the "tck" tests. I have a hard time what "tck" actually means. Could you explain? Maybe: "Test Compatability Kit"? I find the name confusing. Could we * either use the unabbreviated name or * use another more descriptive name?
1 parent 05c01f2 commit f5af6d5

File tree

6 files changed

+14
-11
lines changed

6 files changed

+14
-11
lines changed

.gitignore

+3
Original file line numberDiff line numberDiff line change
@@ -65,3 +65,6 @@ dist/
6565

6666
node-version
6767
neo4j-version
68+
69+
test/tck/
70+
!test/tck/.gitkeep

package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
"prepublish": "npm run build",
1515
"pretest": "npm run build",
1616
"test": "nyc --reporter=lcov ava test/unit/ --verbose",
17-
"parse-tck": "babel-node test/tck/parseTck.js",
18-
"test-tck": "nyc ava --fail-fast test/filterTest.js",
17+
"parse-tck": "babel-node test/helpers/tck/parseTck.js",
18+
"test-tck": "nyc ava --fail-fast test/tck/",
1919
"report-coverage": "nyc report --reporter=text-lcov > coverage.lcov && codecov",
2020
"test-all": "nyc ava test/*.js test/neo4j-schema/*Test.js --verbose",
2121
"debug": "nodemon ./example/apollo-server/movies.js --exec babel-node --inspect-brk=9229 --nolazy",
File renamed without changes.

test/helpers/tck/parseTck.js

+6
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
import { generateTestFile } from './parser';
2+
3+
const TCK_FILE = './test/helpers/tck/filterTck.md';
4+
const TEST_FILE = './test/tck/filterTest.test.js';
5+
6+
generateTestFile(TCK_FILE, TEST_FILE);

test/tck/parser.js test/helpers/tck/parser.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ import { createReadStream, createWriteStream } from 'fs';
44
import {
55
extractTypeMapFromTypeDefs,
66
createOperationMap
7-
} from '../../dist/utils';
8-
import { augmentTypeDefs, cypherQuery } from '../../dist/index';
7+
} from '../../../dist/utils';
8+
import { augmentTypeDefs, cypherQuery } from '../../../dist/index';
99

1010
export const generateTestFile = async (tckFile, testFile) => {
1111
const tck = await extractTck(tckFile, testFile);
@@ -204,7 +204,7 @@ const writeTestFile = (testFile, tck, testDeclarations) => {
204204
const writeStream = createWriteStream(testFile);
205205
writeStream.write(`// Generated by test/tck/parseTck.js
206206
import test from 'ava';
207-
import { filterTestRunner } from './helpers/filterTestHelpers';
207+
import { filterTestRunner } from '../helpers/filterTestHelpers';
208208
209209
const typeDefs = \`
210210
${typeDefs}

test/tck/parseTck.js

-6
This file was deleted.

0 commit comments

Comments
 (0)