-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Bridge new methods #1497
Merged
Merged
Bridge new methods #1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56cf94f
to
8d61996
Compare
Kudos, SonarCloud Quality Gate passed! |
josedahlquist
previously approved these changes
Apr 12, 2021
…d, returns empty byte array
…nding on RSKIP220 activation
8d61996
to
397b91c
Compare
ajlopezrsk
approved these changes
Apr 13, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New public methods added to brdige, only for queries
Motivation and Context
Implements RSK220
The activation is Iris
The methods are
getBtcBlockchainBestBlockHeader()
getBtcBlockchainBlockHeaderByHash(hash)
getBtcBlockchainBlockHeaderByHeight(height)
getBtcBlockchainParentBlockHeaderByHash(hash)
How Has This Been Tested?
Code tests were added for new methods in
Bridge
andBridgeSupport
A manuel test:
Install
npm install rskclitools -g
In a working folder, execute
where
bridge.js
isTypes of changes
Checklist: