Skip to content

Support close in RSocketClient that notifies of the result #1048

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
rstoyanchev opened this issue May 6, 2022 · 0 comments
Closed

Support close in RSocketClient that notifies of the result #1048

rstoyanchev opened this issue May 6, 2022 · 0 comments
Labels
enhancement superseded Issue is superseded by another

Comments

@rstoyanchev
Copy link
Contributor

rstoyanchev commented May 6, 2022

RSocketClient implements Disposable which provides a way to initiate a shutdown. However, there is no good way to hold for the result, and it is important in some cases to wait for that. For example, in components that expose start/stop lifecycle methods and could be started and stopped multiple times. Likewise in tests to ensure resources are released before continuing.

By comparison RSocket implements Closeable so technically possible to access the underlying source RSocket and call close() on that but that could cause a session to be started if not already connected. It would be better to align the two and expose a similar option at the level of RSocketClient as well.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement superseded Issue is superseded by another
Projects
None yet
Development

No branches or pull requests

2 participants