-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Support Rails 6.1 #2398
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Support Rails 6.1 #2398
Conversation
2b96b67
to
1d5c121
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I've missed the last build results, wondering how many things are broken.
1d5c121
to
8962fdc
Compare
The #config option is removed from activerecord/lib/active_record/test_fixtures.rb
8962fdc
to
62b8350
Compare
I do not understand why it is not able to find 3.10.0.pre. I have no issue locally to find them.
To test the CI, I switched 4012de7 |
@benoittgt @pirj My intent for this branch is to use it as dev / maintenance root branch so could you PR to it rather than push commits directly, especially for WIP commits... (I really don't want force pushing to happen to this branch, as I want it available to be used by people running Rails 6.1 from git) |
4012de7
to
62b8350
Compare
@benoittgt I'm going to unpick your commits to a PR, from now on can everyone PR to this branch and that should be the last force push |
Update expected rspec versions
Improve controller template when no action
Move MRI build to Github Actions
Build updates
I just lauch a CI build for Rails v6.1.0.rc2 https://github.com/rspec/rspec-rails/actions/runs/396008092 Edit: success ✅ https://github.com/rspec/rspec-rails/actions/runs/396108630 |
Ok. 3 commits need to be cherry pick if we want to make it workable rails-6-1-dev...rails-6.1.0.rc2-dev We will still have the current issue in the CI with Rails master and dependencies resolving. Should we have rails-6.1.0.rc2 + rails master in the CI for this branch? |
Sure, why not both? As long if we don't set |
Yes I am in favor of both. |
This branch will become the root of Rails 6.1 development. The plan would be to launch this as a new version when Rails 6.1 is released, likely a major version as Rails versions supported will change.
Edit This will not be merged until we are ready to release the next version, it will be used as an available branch for those working on 6.1.
Todo: