Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Made a link to 4-0-maintenance branch #2471

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

hxrxchang
Copy link
Contributor

I think it would be useful if this warning has a link to the specified branch.

@hxrxchang hxrxchang force-pushed the add-link-to-4-0-maintenance branch from 744826d to 81c0a8a Compare March 1, 2021 12:45
@hxrxchang hxrxchang force-pushed the add-link-to-4-0-maintenance branch from 81c0a8a to 67682f5 Compare March 1, 2021 12:50
@hxrxchang hxrxchang changed the title made a link to 4-0-maintenance branch Made a link to 4-0-maintenance branch Mar 1, 2021
Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pirj
Copy link
Member

pirj commented Mar 1, 2021

3.0 failure is unrelated:

/opt/hostedtoolcache/Ruby/3.0.0/x64/lib/ruby/gems/3.0.0/gems/aruba-0.14.14/lib/aruba/platforms/unix_environment_variables.rb:213: [BUG] Segmentation fault at 0x000000322e300000

@pirj pirj merged commit ee251b7 into rspec:main Mar 1, 2021
@pirj
Copy link
Member

pirj commented Mar 1, 2021

Would you like to contribute a similar change against rails-6-1-dev branch that will be released as 4.1?

@hxrxchang
Copy link
Contributor Author

@pirj Thanks for merging! OK! I'll do it.

@hxrxchang hxrxchang deleted the add-link-to-4-0-maintenance branch March 1, 2021 13:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants