Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix method name truncation for multibyte strings (redux) #2487

Merged
merged 3 commits into from
Mar 17, 2021

Conversation

JonRowe
Copy link
Member

@JonRowe JonRowe commented Mar 17, 2021

This just reworks the spec for #2405

y-yagi and others added 3 commits March 17, 2021 08:03
`String#[]` returns a value that considers multibyte value. But some
file systems use byte for maximum filename length. So if applications
use that file system and multibyte value to a method name, currently
check doesn't work expected.

This PR fixes to use `String#byteslice` instead of `String#[]`. Also,
added `String#scrub` to avoid generating an invalid byte sequence.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants